Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add examples to --help output for "gpg_list" #16017

Merged
merged 2 commits into from
Oct 27, 2023
Merged

feat: Add examples to --help output for "gpg_list" #16017

merged 2 commits into from
Oct 27, 2023

Conversation

Ratangulati
Copy link
Contributor

@Ratangulati Ratangulati commented Oct 18, 2023 •
edited
Loading

Created another issue for the issue #15690. #L42

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@Ratangulati Ratangulati requested review from a team as code owners October 18, 2023 15:45
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (9e0e8d5) 49.62% compared to head (b66a66f) 49.60%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #16017      +/-   ##
==========================================
- Coverage   49.62%   49.60%   -0.02%     
==========================================
  Files         267      267              
  Lines       46479    46490      +11     
==========================================
  Hits        23063    23063              
- Misses      21144    21155      +11     
  Partials     2272     2272
Files Coverage Δ
cmd/argocd/commands/gpg.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ratangulati
updated file
b66a66f 
Signed-off-by: Ratan Gulati <[email protected]>
@crenshaw-dev crenshaw-dev merged commit 9b1fb1d into argoproj:master Oct 27, 2023
27 checks passed
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
@Ratangulati @ymktmk
feat(cli): Add examples to --help output for "gpg_list" (argoproj#16017)
ab1dc9d 
* feat: Add examples to --help output for list

Signed-off-by: Ratan Gulati <[email protected]>

* updated file

Signed-off-by: Ratan Gulati <[email protected]>

---------

Signed-off-by: Ratan Gulati <[email protected]>
Signed-off-by: ymktmk <[email protected]>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@Ratangulati @jmilic1
feat(cli): Add examples to --help output for "gpg_list" (argoproj#16017)
317a3ed 
* feat: Add examples to --help output for list

Signed-off-by: Ratan Gulati <[email protected]>

* updated file

Signed-off-by: Ratan Gulati <[email protected]>

---------

Signed-off-by: Ratan Gulati <[email protected]>
Signed-off-by: jmilic1 <[email protected]>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@Ratangulati @vladfr
feat(cli): Add examples to --help output for "gpg_list" (argoproj#16017)
2ce7b17 
* feat: Add examples to --help output for list

Signed-off-by: Ratan Gulati <[email protected]>

* updated file

Signed-off-by: Ratan Gulati <[email protected]>

---------

Signed-off-by: Ratan Gulati <[email protected]>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@Ratangulati @tesla59
feat(cli): Add examples to --help output for "gpg_list" (argoproj#16017)
af162b0 
* feat: Add examples to --help output for list

Signed-off-by: Ratan Gulati <[email protected]>

* updated file

Signed-off-by: Ratan Gulati <[email protected]>

---------

Signed-off-by: Ratan Gulati <[email protected]>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@Ratangulati @lyda
feat(cli): Add examples to --help output for "gpg_list" (argoproj#16017)
f2bddc6 
* feat: Add examples to --help output for list

Signed-off-by: Ratan Gulati <[email protected]>

* updated file

Signed-off-by: Ratan Gulati <[email protected]>

---------

Signed-off-by: Ratan Gulati <[email protected]>
Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@Ratangulati @Hariharasuthan99
feat(cli): Add examples to --help output for "gpg_list" (argoproj#16017)
f307236 
* feat: Add examples to --help output for list

Signed-off-by: Ratan Gulati <[email protected]>

* updated file

Signed-off-by: Ratan Gulati <[email protected]>

---------

Signed-off-by: Ratan Gulati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ratangulati @crenshaw-dev @ishitasequeira